Minor fixes and download stellar spectrum #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etimes caused weird behaviour. Updated tests accordingly, with minor changes overall
lsoucasse
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
Great! Things are starting to fall into place. It is much better to discriminate spectral files associated with the atmosphere and spectral files associated with the star.
I am wondering if all these stellar spectra should better fit into Mors but I think for now it is OK.
|
Thanks! Yes, it would make more sense if they were downloaded by MORS instead of by JANUS. The spectra are downloaded to the shared FWL data folder regardless, but maybe the functions themselves should be moved. |
lsoucasse
added a commit
that referenced
this pull request
Sep 24, 2024
Minor fixes and download stellar spectrum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now downloads stellar spectra from here: https://osf.io/8r2sw/, rather than using precomputed files in the spectral_files folder. This is important because the old files were outdated and not in a format consistent with what Mors produces. They were in the SOCRATES format with SI units and a specific header.
The spectra are now converted into the SOCRATES format by JANUS when they are inserted into the spectral file. This is done with
PrepareStellarSpectrumin the same manner as in PROTEUS. The files produced bymors.SpectrumWritecan then be parsed appropriately.As a result, the solar spectrum used by JANUS by default is slightly different to the previous one. The test reference values have been updated accordingly, but they only differ by a few decimal places.